Setup shared components #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitmalhotra1420
requested changes
Dec 9, 2024
| @@ -0,0 +1,632 @@ | |||
| import { blocksTheme } from 'blocks/theme/Theme'; | |||
|
|
|||
There was a problem hiding this comment.
@riyanshu-patro you don't need this file. Please follow the same approach as done in push wallet.
There was a problem hiding this comment.
Also move the theme config in wallet ap to the blocks theme file.
| @@ -0,0 +1 @@ | |||
| export { useIsVisible } from './useIsVisible'; | |||
There was a problem hiding this comment.
We also need useDarkMode hook here.
- This hook doesn't exist in dapp so you can ad it there as well.
| ## Expanding the ESLint configuration | ||
|
|
||
| If you are developing a production application, we recommend updating the configuration to enable type aware lint rules: | ||
|
|
| @@ -0,0 +1,32 @@ | |||
| import { defineConfig } from 'vite'; | |||
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
See if we actually needs this files or could we remove it.
Don't think it should be a vite project.
rohitmalhotra1420
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.